Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts enabled SDK + transport package #39

Merged
merged 3 commits into from
May 16, 2024

Conversation

daniel-de-vera
Copy link
Contributor

@daniel-de-vera daniel-de-vera commented May 14, 2024

This PR:

  • Includes the artifacts methods (note there was an upgrade in github.com/go-swagger/go-swagger/cmd/swagger and that's why there are so many changed files).
  • It also adds RouteGroup.Defaults and Sandbox.Defaults and sandbox.Readiness.scheduledDeleteTime that I wasn't sure if we wanted them or not (but there was no swaggerignore for those fields). CC: @foxish.
  • Adds a transport package to support accessing the base API and artifacts API via separate endpoints (useful for local dev).

Copy link
Member

@scott-cotton scott-cotton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-de-vera daniel-de-vera merged commit 87dfff7 into main May 16, 2024
1 check passed
@daniel-de-vera daniel-de-vera deleted the artifacts-enabled-sdk branch May 16, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants