Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of LocalMachineID to SandboxSpec #36

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Addition of LocalMachineID to SandboxSpec #36

merged 1 commit into from
Nov 20, 2023

Conversation

daniel-de-vera
Copy link
Contributor

This is in the context of issue https://github.com/signadot/signadot/issues/3837.

@daniel-de-vera daniel-de-vera mentioned this pull request Nov 7, 2023
Merged
scott-cotton
scott-cotton approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@scott-cotton scott-cotton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-de-vera daniel-de-vera merged commit 5aa0810 into main Nov 20, 2023
2 checks passed
@daniel-de-vera daniel-de-vera deleted the sandbox-local-machine-id branch November 20, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scott-cotton scott-cotton scott-cotton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-de-vera @scott-cotton