Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for local machine ID #91

Merged
merged 11 commits into from
Nov 20, 2023
Merged

Add support for local machine ID #91

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
af498ef
WIP: checkpoint
daniel-de-vera Nov 6, 2023
58fd74b
Release candidate changes
daniel-de-vera Nov 7, 2023
96c0d06
Bug fix
daniel-de-vera Nov 7, 2023
3bb0bc0
Another fix
daniel-de-vera Nov 8, 2023
29778f8
Reflect changes in tunnel API spec
daniel-de-vera Nov 9, 2023
bd37be9
Remove unneeded code.
daniel-de-vera Nov 9, 2023
eaf51d8
Get rid of API and API key in locald command
daniel-de-vera Nov 9, 2023
399b23e
Implementation of sandboxes watcher status (#92)
daniel-de-vera Nov 15, 2023
47283b3
Add support for old operators (< 0.14.1) (#94)
daniel-de-vera Nov 17, 2023
54bc79c
Include operator info as par of the status (#95)
daniel-de-vera Nov 20, 2023
45d579d
Merge remote-tracking branch 'origin/main' into sandbox-machineID
daniel-de-vera Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/locald/sandboxmanager/sandbox_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ func newSBController(log *slog.Logger, sandbox *tunapiv1.WatchLocalSandboxesResp
}
// run the controller
go ctrl.run()
// trigger a reconcile
ctrl.triggerReconcile()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this in ctrl.run() so it is more self-contained.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed this in #94

return ctrl
}

Expand Down