Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coding style and PEP8 violations #86

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GreenK173
Copy link
Contributor

Fixes occasional coding style inconsistencies, too long lines and other PEP8 violations (according to pyproject.toml, this library should with formatted by Black with line length 120).

@Teque5
Copy link
Collaborator

Teque5 commented Dec 14, 2024

We've been aware of these for a while and just didn't want to have a commit that touched so many files at once. I was gradually fixing them as PRs for individual files were created. Once I look at your other PRs I can reconsider this one.

Copy link
Collaborator

@Teque5 Teque5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending one change, let's merge this after #85 and #93 are merged.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not change this file. This is one of those edge cases where black makes things much worse.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can insert # fmt: skip to skip an individual line for the formatter or use # fmt: off and # fmt: on to disable for regions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants