num_channels wording and updated github action to be able to view pdf/html as an artifact #319
Conversation
777arc
changed the title
|
You can preview the new docs under GitHub's "Actions" menu at the top, click the run that corresponds to your PR, scroll down to "Artifacts", download the artifact named "out", unzip it, and you should be able to see the html and pdf. Maybe one day I'll make it so that it publishes the html/pdf at https://sigmf.org/pr-name/ so that you just click a link to immediately preview things. |
|
@jacobagilbert I think I addressed the suggestions but go ahead and edit it directly if you want to make any tweaks, here's a direct link to editing that line of my branch - https://github.com/sigmf/SigMF/edit/777arc-patch-1/additional_content.md?#L165 |
There was a problem hiding this comment.
At a minimum rename that zip file per my code comment. Without pandoc the zip is 1MB vs 125MB. I believe you can use wildcards to select the files you want.
Note that actions/upload-artifact@v3 is being deprecated for v4 per here.
Co-authored-by: Teque5 <[email protected]>
Co-authored-by: Teque5 <[email protected]>
No description provided.