Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable caching feature of wireit in GitHub Actions #91

Closed
wants to merge 2 commits into from

Conversation

pddg
Copy link
Contributor

@pddg pddg commented Mar 3, 2024

wireit has its own caching feature. This PR enables it by adding the action provided officially.
https://github.com/google/wireit?tab=readme-ov-file#github-actions-caching

And, I added Node v20.x to the target of CI.

@siefkenj
Copy link
Owner

siefkenj commented Mar 3, 2024

Thanks for the contribution! But I don't want to enable caching. In my experience it is very easy to misconfigure wireit and its cache may cover up a build error. I want the CI builds to start fresh, without any cache :-)

@pddg
Copy link
Contributor Author

pddg commented Mar 3, 2024

Oh, I see. I will add Node v20 to the build matrix in a separate PR.

@pddg pddg closed this Mar 3, 2024
@pddg pddg deleted the pddg/wireit-cache branch March 3, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants