Pull requests list feat: support embellishments and non-punctuation delimiters #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that e{{_}} has the same effect as e{_}. e{{{_}}} triggers an
error. This commit reflects this behavior in `gobbleSingleArgument`
function.
gobbleSingleArguments return values
Now gobbleSingleArgument gobbles single argument for each run, and may mutates its parameter argspec to remove gobbled arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modification of PR #42
Previously, it couldn't attach arguments for macros whose argspec
e{_},E{^}{default},r^_This PR adds support for it. The second use-case may be marginal, I initially tried to make embellishments work, then realized that the same code would enable the second feature and unifies some codes.
Since a single embellishment argspec can represent multiple arguments, such as in
e{^_}where each token^and_would represents 2 arguments,gobbleSingleArguments signature was changed to returnAst.Arguments | Ast.Arguments[] | null.Currently, this just puts embellishment tokens as
openMarkin Ast. Would it be preferable to have a new separate property for embellishments?Next goal would be to support/test macro expansions for such arguments. Once it's done, I'd like to work on #24.
Please take a look and provide comments, and feel free to make your own changes!