fix: include trait bounds in where clause of From<JsValue> #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should once and for all (I hope 😅) fix #25
I also updated the e2e test to catch the case of trait bounds (and even lifetime constraint)
However I am not very satisfied by this fix because it actually replaces
Self
in where clause with the type on which we are implementingIntoWasmAbi
andFrom<JsValue>
which I think is a bit hacky and maybe not how thesyn::Generics
interface is intended to be used.A "more
syn
friendly interface" could be to not implementFrom<JsValue>
butInto
directly and useSelf
as usual, this will however require to disable a clippy warning.So every solution I think of are meh, one thing for sure: we really need those e2e tests with more case coverage 😬
Let me know if you have a better idea to fix this @siefkenj @nappa85