-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: into_wasm_abi requiring unnecessary trait bound #25
Comments
I suspect my PR #22 may have done it 😅 I will take a look at this. |
It should be fixed by #26 can you test it ? I have an annoying warning about an unused field when compiling, do you have it too ? |
Now it works, the only negative detail is the warning
But it isn't related to this issue |
Nice ! Thanks for testing the fix 👍 Yeah I may usually get such warning in rust analyser too, I think it comes from |
Not sure about that, I remember someone pointed it out on |
Should be fixed in |
Sorry to reopen, but I've just found another problem: #[derive(serde::Serialize, tsify_next::Tsify)]
#[tsify(into_wasm_abi)]
pub struct Identified<Id, Value>
where
Id: Send,
{
pub id: Id,
pub value: Value,
} Any trait bound, in this example |
@nappa85 I made another fix and improve our test to cover such cases. If you have other edge case where it does not work, let us know ! |
I really hope the edge cases are terminated |
This works with
tsify
, upgrading totsify-next
it starts giving an error aboutId
andValue
not having a bound onserde::Serialize
The text was updated successfully, but these errors were encountered: