Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rp contri doc #85

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

Conversation

RussellPacheco
Copy link

Thank you for contributing to Phantom!

👻 Please review our contribution guidelines.

Description

What changes did you make? ⚠️ DO NOT LEAVE EMPTY

There was a broken link in CONTRIBUTING.md. It was the CODEOFCONDUCT.md. Should be CODE_OF_CONDUCT.md

@sidiousvic
Copy link
Owner

Thanks @RussellPacheco! All tests pass, however—there's a small issue.

I see that 14 files has been changed—I recreated the dev branch a few minutes ago, and it looks like your commit might have carried to old version of dev.

Can you delete the dev branch locally, pull again, and enact the PR for CONTRIBUTING.md?

To recreate the latest dev branch:

git checkout production
git pull
git branch -d dev
git checkout dev

After that you should be able to make a new PR. Sorry for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants