Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable nct6683 sensors as module #846

Merged
merged 1 commit into from
Dec 14, 2023
Merged

feat: enable nct6683 sensors as module #846

merged 1 commit into from
Dec 14, 2023

Conversation

JJGadgets
Copy link
Contributor

The Lenovo Tiny M720q, as well as other Lenovo Tiny ThinkCentres (https://forums.servethehome.com/index.php?threads/lenovo-thinkcentre-thinkstation-tiny-project-tinyminimicro-reference-thread.34925/), uses this kernel module to expose hardware sensor metrics such as voltages, fan speed, and temperatures (CPU and others).

@JJGadgets
Copy link
Contributor Author

JJGadgets commented Dec 11, 2023

Do I need to re-commit using my actual PGP key to sign the commit? I used GitHub.com to edit the file and PR so it's currently signed with their key.

Edit: nevermind, I see that the PGP identity needs to be from a member of the Sidero org, so I'll leave the commit as is.

@JJGadgets
Copy link
Contributor Author

Re-committed and force-pushed anyway for the DCO.

@frezbo
Copy link
Member

frezbo commented Dec 12, 2023

thanks 👍 , will clean up and merged

@smira
Copy link
Member

smira commented Dec 12, 2023

let's merge after #844

@smira
Copy link
Member

smira commented Dec 14, 2023

/m

The Lenovo Tiny M720q, as well as other Lenovo Tiny ThinkCentres (https://forums.servethehome.com/index.php?threads/lenovo-thinkcentre-thinkstation-tiny-project-tinyminimicro-reference-thread.34925/), uses this kernel module to expose hardware sensor metrics such as voltages, fan speed, and temperatures (CPU and others).

Signed-off-by: JJGadgets <[email protected]>
Signed-off-by: Noel Georgi <[email protected]>
@frezbo
Copy link
Member

frezbo commented Dec 14, 2023

/m

@talos-bot talos-bot merged commit e325097 into siderolabs:main Dec 14, 2023
14 checks passed
@JJGadgets JJGadgets deleted the patch-1 branch December 14, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Backported
Development

Successfully merging this pull request may close these issues.

4 participants