feat: properly handle powered off machines in the UI and machine classes #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix4ever
force-pushed
the
support-bare-metal-powered-off-machines
branch
from
3d2d3a9 to
59c4145
Compare
Introduce the new label `omni.sidero.dev/ready-to-use`, which is now used in the UI when creating/scaling a cluster and in the machine set scaling controller instead of `omni.sidero.dev/connected`. The machine status controller was changed to add the ready to use label when the machine is created by the bare metal infra provider. Then the controller looks on the state of the `InfraMachineStatus` resource and sets `omni.sidero.dev/ready-to-use` label when the `ReadyToUse` flag is true in the `InfraMachineStatus`. If the machine is managed by the bare metal infra provider and is not a part of a cluster we no longer set `omni.sidero.dev/disconnected` label. It is used only in the UI. We still remove `connected` label when the machine gets disconnected from Omni. Update the `MachineStatus` resource to also include power state of the machine. Then display it in the UI for the machines list. Introduce `POWERING_ON` stage in the cluster machine status. Although it doesn't cover the power on stage fully. It will show powering on only for a short period until the bare metal provider issues the power on. We can improve that in the follow-up PR when we start tracking powering on stage more precisely. Fixes: siderolabs#774 Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever
force-pushed
the
support-bare-metal-powered-off-machines
branch
from
59c4145 to
34dd2ae
Compare
utkuozdemir
approved these changes
Dec 20, 2024
|
🆒 |
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the new label
omni.sidero.dev/ready-to-use, which is now used in the UI when creating/scaling a cluster and in the machine set scaling controller instead ofomni.sidero.dev/connected.The machine status controller was changed to add the ready to use label when the machine is created by the bare metal infra provider. Then the controller looks on the state of the
InfraMachineStatusresource and setsomni.sidero.dev/ready-to-uselabel when theReadyToUseflag is true in theInfraMachineStatus.If the machine is managed by the bare metal infra provider and is not a part of a cluster we no longer
set
omni.sidero.dev/disconnectedlabel. It is used only in the UI. We still removeconnectedlabel when the machine gets disconnected from Omni.Update the
MachineStatusresource to also include power state of the machine. Then display it in the UI for the machines list.Introduce
POWERING_ONstage in the cluster machine status. Although it doesn't cover the power on stage fully. It will show powering on only for a short period until the bare metal provider issues the power on. We can improve that in the follow-up PR when we start tracking powering on stage more precisely.The new UI:
Fixes: #774