fix: do not preserve extensions on Talos agent mode #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix4ever
reviewed
Dec 20, 2024
frezbo
reviewed
Dec 20, 2024
internal/backend/runtime/omni/controllers/omni/internal/talos/schematic.go
Show resolved
Hide resolved
If Talos is in agent mode, we should avoid preserving the list of extensions for the actual Talos installation, as the `metal-agent` extension breaks the Talos installation. Signed-off-by: Utku Ozdemir <[email protected]>
utkuozdemir
force-pushed
the
agent-mode-schematic
branch
from
68a68e5 to
1d8c754
Compare
utkuozdemir
commented
Dec 20, 2024
Comment on lines
+434
to
+443
| id := "test-" + tt.name | ||
|
|
||
| machine := omni.NewMachine(resources.DefaultNamespace, id) | ||
| spec := machine.TypedSpec().Value | ||
|
|
||
| spec.Connected = true | ||
| spec.ManagementAddress = suite.socketConnectionString | ||
|
|
||
| suite.Require().NoError(suite.state.Create(suite.ctx, machine)) | ||
|
|
There was a problem hiding this comment.
Moved this here to create a different machine ID each time - otherwise MachineStatus preserves the initial schematic, and my new test was giving different results when it was run in isolation vs when it was run together with other tests.
done |
Unix4ever
approved these changes
Dec 20, 2024
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Talos is in agent mode, we should avoid preserving the list of extensions for the actual Talos installation, as the
metal-agentextension breaks the Talos installation.Related to/workaround for #797