Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.html with relative paths to css and js files #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

index.html with relative paths to css and js files #58

wants to merge 1 commit into from

Conversation

krandalf75
Copy link

Make poly more reverse proxy friendly: Use relative paths to load javascript and css so they are loaded from /poli/static instead /static. So we don't need to publish /static folder.

@codecov-io
Copy link

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #58   +/-   ##
=========================================
  Coverage     65.36%   65.36%           
  Complexity      406      406           
=========================================
  Files            51       51           
  Lines          1611     1611           
  Branches        141      141           
=========================================
  Hits           1053     1053           
  Misses          513      513           
  Partials         45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23d6e2...9ece6c8. Read the comment docs.

@shzlw
Copy link
Owner

shzlw commented Jan 4, 2020

Hey man. Thanks for the PR. I tested it and it works well. The only problem is if I refresh the page for example, http://localhost:6688/poli/workspace/report. All resource files are redirected to http://localhost:6688/poli/workspace/static/css/2.07f54ecf.chunk.css from http://localhost:6688/static/css/2.07f54ecf.chunk.css and return 404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants