fix: fix wrong history when using client side loader redirect

shuvijs · Oct 13, 2023 · 177742b · 177742b
1 parent 8d14c6a
commit 177742b
Show file tree

Hide file tree

Showing 10 changed files with 1,033 additions and 41 deletions.
diff --git a/packages/platform-web/src/shuvi-app/app/client.ts b/packages/platform-web/src/shuvi-app/app/client.ts
@@ -139,10 +139,7 @@ export const createApp: CreateAppClient = ({
         if (isThirdSite(location)) {
           window.location.replace(location);
         } else {
-          next({
-            path: location,
-            replace: true
-          });
+          next(location);
         }
         runLoadersTrace.setAttribute(
           SHUVI_CLIENT_RUN_LOADERS.attrs.errorType.name,

diff --git a/packages/platform-web/src/shuvi-app/app/server.ts b/packages/platform-web/src/shuvi-app/app/server.ts
@@ -67,6 +67,8 @@ export const createApp: CreateAppServer = options => {
         if (isRedirect(error)) {
           const location = error.headers.get('Location')!;
           const status = error.status;
+          // server side redirect is different from regular route redirect because it has the extra data - statusCode
+          // So it won't change route target, but just store the redirect location in state
           next({
             path: pathToString(to),
             replace: true,