Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary release #1858

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Fix binary release #1858

merged 2 commits into from
Dec 5, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Dec 4, 2024

In instaclustr/atsc#141 I discovered that shotover's compiled binary had a bug preventing it from being included in releases for over a year.

This PR applies the same fix as done in the ATSC repo, which fixed the problem over there.

Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #1858 will degrade performances by 10.69%

Comparing rukai:fix_binary_release (445ea61) with main (5a40ec0)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main rukai:fix_binary_release Change
encode_request_list_offsets 10.8 µs 12.1 µs -10.69%

@rukai rukai enabled auto-merge (squash) December 5, 2024 05:20
@rukai rukai merged commit d754774 into shotover:main Dec 5, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants