Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix valkey test_save #1838

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Fix valkey test_save #1838

merged 4 commits into from
Nov 26, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 25, 2024

On a sufficiently fast machine these tests fail since the timestamps are equal.
The fix is to use >= comparison to allow the equal case to also pass the test.

Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #1838 will not alter performance

Comparing rukai:fix_valkey_test_save (cf1d4f2) with main (de3658e)

Summary

✅ 38 untouched benchmarks

@rukai rukai enabled auto-merge (squash) November 25, 2024 23:07
@rukai rukai merged commit a6a4b1c into shotover:main Nov 26, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants