Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster: Error on AlterReplicaLogDirs #1837

Merged
merged 3 commits into from
Nov 26, 2024
Merged

KafkaSinkCluster: Error on AlterReplicaLogDirs #1837

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb16112
KafkaSinkCluster: Error on AlterReplicaLogDirs
rukai Nov 25, 2024
70cb82f
Merge branch 'main' into error_on_alter_replica_log_dirs
rukai Nov 26, 2024
49944ea
Merge branch 'main' into error_on_alter_replica_log_dirs
rukai Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions shotover/src/transforms/kafka/sink_cluster/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,6 +1128,18 @@ Shotover cannot handle this request as it is not appropriate for shotover to shu
The connection to the client has been closed."
));
}
Some(Frame::Kafka(KafkaFrame::Request {
body: RequestBody::AlterReplicaLogDirs(_),
..
})) => {
return Err(anyhow!(
"Client sent AlterReplicaLogDirs request.
Shotover has not implemented support for this message type.
It could theoretically be supported by performing the inverse of DescribeLogDirs.
i.e. Define a custom path format like `actual-kafka-broker-id3:/original/log/dir/path` and then parse the broker id and send the original path to that broker.
But it is expected that if you are using shotover as a proxy you do not care about the internal state of the kafka cluster enough to use AlterReplicaLogDirs."
));
}
Some(Frame::Kafka(KafkaFrame::Request {
body: RequestBody::UnregisterBroker(_),
..
Expand Down
Loading