Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster - move destination field from PendingRequestState into PendingRequest #1828

Conversation

alleyshairu
Copy link
Contributor

This PR address #1763

It removes the destination associated field from all of the variants of the PendingRequestState enum, and moves this state to the parent type PendingRequest.

This eliminates the need to pass the destination when transitioning between states.

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #1828 will not alter performance

Comparing alleyshairu:kafka_pending_request_state_destination_refactoring (6e2ee0e) with main (6a053ae)

Summary

✅ 38 untouched benchmarks

@alleyshairu alleyshairu marked this pull request as ready for review November 21, 2024 05:21
@rukai
Copy link
Member

rukai commented Nov 21, 2024

Thanks, this is great!
Everything passed CI, I'll hit "Update branch" and if everything still passes we'll approve the PR.
Theres been a lot of activity in this file lately so unfortunately its not unlikely that something might break.

@rukai rukai merged commit 395ca02 into shotover:main Nov 21, 2024
41 checks passed
@rukai rukai mentioned this pull request Nov 21, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants