Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RedisFrame to ValkeyFrame and all relevant files #1822

Merged
merged 10 commits into from
Nov 21, 2024

Conversation

ronycsdu
Copy link
Collaborator

No description provided.

Copy link

codspeed-hq bot commented Nov 19, 2024

CodSpeed Performance Report

Merging #1822 will degrade performances by 10.1%

Comparing INS-33141-redis-to-valkey-part-1 (bded2ce) with main (f82a6ca)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main INS-33141-redis-to-valkey-part-1 Change
encode_request_list_offsets 11 µs 12.2 µs -10.1%

@ronycsdu ronycsdu marked this pull request as ready for review November 19, 2024 06:57
@rukai rukai mentioned this pull request Nov 19, 2024
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The remaining renames will be done in a follow up PR.

However, before we merge this, lets merge #1824 so that we can do a final 0.5.x release before putting breaking changes on main branch.
After this PR is merged the next release will be 0.6.0

@rukai rukai enabled auto-merge (squash) November 21, 2024 03:15
@rukai rukai merged commit 6a053ae into main Nov 21, 2024
40 of 41 checks passed
@rukai rukai deleted the INS-33141-redis-to-valkey-part-1 branch November 21, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants