Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster: Add kafka 3.9 integration test #1821

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 18, 2024

While we do not need to support kafka 3.9 yet, adding an integration test for it is very useful since when investigating how a message type is used in kafka 3.6, being able to check if its used in 3.9 helps rule out if it is actually in 3.6 or not.

To get the integration tests passing with kafka 3.9 I had to handle 2 new message types, this was done by rewriting ApiVersions responses to say that we dont support these message types at all. Refer to the comments in the code for the reasoning.

In the future we could extend the ApiVersions rewriting logic to ensure that future changes to kafka message types dont break shotover, but that is out of scope of this PR.

Copy link

codspeed-hq bot commented Nov 18, 2024

CodSpeed Performance Report

Merging #1821 will not alter performance

Comparing rukai:kafka_3.9 (19ff474) with main (8045ecd)

Summary

✅ 38 untouched benchmarks

@rukai rukai force-pushed the kafka_3.9 branch 2 times, most recently from a522281 to 78a31bb Compare November 18, 2024 05:48
@rukai rukai marked this pull request as ready for review November 18, 2024 22:06
@rukai rukai merged commit 73ac04c into shotover:main Nov 18, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants