KafkaSinkCluster: Add kafka 3.9 integration test #1821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we do not need to support kafka 3.9 yet, adding an integration test for it is very useful since when investigating how a message type is used in kafka 3.6, being able to check if its used in 3.9 helps rule out if it is actually in 3.6 or not.
To get the integration tests passing with kafka 3.9 I had to handle 2 new message types, this was done by rewriting ApiVersions responses to say that we dont support these message types at all. Refer to the comments in the code for the reasoning.
In the future we could extend the ApiVersions rewriting logic to ensure that future changes to kafka message types dont break shotover, but that is out of scope of this PR.