KafkaSinkCluster: route ListGroups request #1790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out to be more complicated than I initially thought.
When
AdminClient.listConsumerGroups
is called, the java driver sends aListGroups
request to all brokers and then combines the responses, removing any duplicate entries.To ensure that all groups are included shotover should also send requests to all brokers and combine them.
However we should avoid sending requests outside of shotovers rack to reduce the load of the operation.
This should still include all the results as the client will query all shotover nodes, and each shotover node will query a portion of the kafka brokers, ensuring all kafka nodes are queried.
A second commit was added to avoid running the new test case in the tests with a down shotover node, since that resulted in test failures as the down shotover node can not report its racks groups.
It might be easier to review that commit separately from the main commit.