KafkaSinkCluster: Split OffsetFetch #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
split_offset_fetch
branch
from
ccbefb0 to
da596fb
Compare
rukai
force-pushed
the
split_offset_fetch
branch
from
da596fb to
ae64cfc
Compare
CodSpeed Performance ReportMerging #1788 will not alter performanceComparing Summary
|
justinweng-instaclustr
approved these changes
Oct 28, 2024
ronycsdu
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1764
I was not able to find a way to reproduce this, I suspect that no drivers actually make use of this functionality.
Regardless, I think we should just handle this correctly since its pretty straightforward to implement.
I'm fairly confident it is correct due to its similarity to other split messages like DeleteGroups that also route by group id.