Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka_int_tests: cleanup delete_groups test #1784

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Oct 25, 2024

This PR cleans up the existing testing for kafka delete_groups:

  • Previously there was an admin_cleanup function in the cpp driver modules that was hardcoded to the cpp driver.
    • this was leftover from the very earliest integration tests we had for kafka
    • This PR moves this logic into the higher level kafka_int_tests module, calling the new KafkaAdmin::delete_groups method
  • Previously the java driver was untested, but this PR adds a delete_groups implementation for the java driver.
  • Previously we ignored some failures in the cpp driver when deleting groups, I've not been able to reproduce those failures, so I just removed the extra handling.

Copy link

codspeed-hq bot commented Oct 25, 2024

CodSpeed Performance Report

Merging #1784 will not alter performance

Comparing rukai:cleanup_delete_groups_test (14db259) with main (421ec9e)

Summary

✅ 38 untouched benchmarks

@rukai rukai force-pushed the cleanup_delete_groups_test branch from ecd0a19 to 944540e Compare October 25, 2024 04:49
@rukai rukai marked this pull request as ready for review October 25, 2024 04:49
@rukai rukai enabled auto-merge (squash) October 25, 2024 09:01
@rukai rukai merged commit 2e91cfb into shotover:main Oct 27, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants