Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates that the extended consumer latency fix can work, as demonstrated by the
produce_consume_partitions3(connection_builder, "partitions3_case4", 1_000_000, 100)
test case passing.However I dont think its worth going ahead with at this time.
The extended solution has no performance impact when
fetch.min.bytes = 1
which is the default value.While at the same time bringing a lot of extra complexity into the implementation which carries some risk.
In particular I would like to see that:
fetch.min.bytes = 1
, in regards to both performance and correctness.fetch.min.bytes > 1
Before considering landing this implementation.
For now, the recommendation is to just not configure clients with
fetch.min.bytes > 1
when connecting to shotover.