Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer latency fix extension #1781

Closed
wants to merge 1 commit into from

Conversation

rukai
Copy link
Member

@rukai rukai commented Oct 21, 2024

This PR demonstrates that the extended consumer latency fix can work, as demonstrated by the produce_consume_partitions3(connection_builder, "partitions3_case4", 1_000_000, 100) test case passing.

However I dont think its worth going ahead with at this time.
The extended solution has no performance impact when fetch.min.bytes = 1 which is the default value.
While at the same time bringing a lot of extra complexity into the implementation which carries some risk.

In particular I would like to see that:

  • shotover runs well in production with fetch.min.bytes = 1, in regards to both performance and correctness.
  • we experience performance issues with fetch.min.bytes > 1

Before considering landing this implementation.

For now, the recommendation is to just not configure clients with fetch.min.bytes > 1 when connecting to shotover.

@rukai rukai force-pushed the consumer_latency_fix_extension branch from 81cd337 to 1b13038 Compare October 21, 2024 05:29
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #1781 will not alter performance

Comparing rukai:consumer_latency_fix_extension (9c1d989) with main (61b5a98)

Summary

✅ 38 untouched benchmarks

@rukai rukai force-pushed the consumer_latency_fix_extension branch from 1b13038 to 9c1d989 Compare October 21, 2024 06:15
@rukai
Copy link
Member Author

rukai commented Oct 28, 2024

Closing as we are not pursuing this at the moment.
Can be reopened if we find a need for it.

@rukai rukai closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant