Split ShotoverNodeConfig::address into address_for_peers and address_for_client #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
address_for_peers/address_for_client
branch
2 times, most recently
from
45ce64b to
8007ab5
Compare
CodSpeed Performance ReportMerging #1780 will not alter performanceComparing Summary
|
rukai
force-pushed
the
address_for_peers/address_for_client
branch
3 times, most recently
from
80a6dff to
2dcfb05
Compare
rukai
changed the title
rukai
force-pushed
the
address_for_peers/address_for_client
branch
from
0111317 to
260dc4e
Compare
ronycsdu
approved these changes
Oct 21, 2024
shotover-proxy/tests/test-configs/kafka/cluster-3-racks/topology-rack1.yaml
Show resolved
Hide resolved
rukai
force-pushed
the
address_for_peers/address_for_client
branch
from
260dc4e to
00cd7cd
Compare
justinweng-instaclustr
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits
ShotoverNodeConfig::addressintoaddress_for_peersandaddress_for_clients.This allows shotover to support previously impossible networking setups where the shotover cluster communicates between itself using different addresses than is used by the clients to connect to the cluster.
The implementation is very straightforward: just replace the existing field with 2 new fields and use those fields in the appropriate places.