Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka integration tests - wait for topics to be created #1777

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Oct 17, 2024

This PR attempts to resolve intermittent failures such as https://github.com/shotover/shotover-proxy/actions/runs/11378756458/job/31655385620 by adding a check after topic creation that all the created topics have propagated across the cluster.

To do that we:

  • java driver - extend the createTopics wrapper to allow querying multiple topics at once and return the number of partitions for each topic.
  • cpp driver - just add a sleep, the rust wrapper for the driver doesnt support describeTopics yet.

@rukai rukai marked this pull request as draft October 17, 2024 06:39
Copy link

codspeed-hq bot commented Oct 17, 2024

CodSpeed Performance Report

Merging #1777 will create unknown performance changes

Comparing rukai:describe_topics (89892c6) with main (3c59dad)

Summary

🆕 38 new benchmarks

Benchmarks breakdown

Benchmark main rukai:describe_topics Change
🆕 cassandra_protect_protected N/A 73 µs N/A
🆕 cassandra_protect_unprotected N/A 42.2 µs N/A
🆕 cassandra_request_throttling_unparsed N/A 14.2 µs N/A
🆕 cassandra_rewrite_peers_passthrough N/A 81.3 µs N/A
🆕 loopback N/A 6.4 µs N/A
🆕 nullsink N/A 14.1 µs N/A
🆕 query_counter_fresh N/A 14.4 µs N/A
🆕 query_counter_pre_used N/A 11.2 µs N/A
🆕 redis_cluster_ports_rewrite N/A 18.1 µs N/A
🆕 redis_filter N/A 22.5 µs N/A
🆕 decode_system.local_query_v4_lz4_compression N/A 54.4 µs N/A
🆕 decode_system.local_query_v4_no_compression N/A 54.2 µs N/A
🆕 decode_system.local_query_v5_lz4_compression N/A 56.3 µs N/A
🆕 decode_system.local_query_v5_no_compression N/A 56.1 µs N/A
🆕 decode_system.local_result_v4_lz4_compression N/A 46.6 µs N/A
🆕 decode_system.local_result_v4_no_compression N/A 14.5 µs N/A
🆕 decode_system.local_result_v5_lz4_compression N/A 46.6 µs N/A
🆕 decode_system.local_result_v5_no_compression N/A 14.5 µs N/A
🆕 encode_system.local_query_v4_lz4_compression N/A 13.6 µs N/A
🆕 encode_system.local_query_v4_no_compression N/A 14.1 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@rukai rukai changed the title describe_topics test kafka integration tests - wait for topics to be created Oct 17, 2024
@rukai rukai marked this pull request as ready for review October 17, 2024 23:10
@conorbros conorbros enabled auto-merge (squash) October 17, 2024 23:58
@conorbros conorbros merged commit d8b0e59 into shotover:main Oct 18, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants