Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable local_result_v5_no_compression benchmark for being noisy #1775

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Oct 15, 2024

To stop this noisy bench from showing up as a failure I propose we comment it out. See comment in the code changes for more info.

Copy link

codspeed-hq bot commented Oct 15, 2024

CodSpeed Performance Report

Merging #1775 will not alter performance

Comparing rukai:disable_noisy_bench (fa8d770) with main (ce25cc4)

Summary

✅ 38 untouched benchmarks

⁉️ 1 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main rukai:disable_noisy_bench Change
⁉️ encode_system.local_result_v5_no_compression 93.1 µs N/A N/A

@rukai rukai merged commit de0fca3 into shotover:main Oct 15, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants