Allow disabling shotover peers check #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
make_shotover_peers_check_optional
branch
from
9e99bca to
1a651a6
Compare
CodSpeed Performance ReportMerging #1773 will not alter performanceComparing Summary
|
|
Should |
rukai
force-pushed
the
make_shotover_peers_check_optional
branch
from
1a651a6 to
fbd7ba4
Compare
|
yeah thats a good idea, done. |
rukai
force-pushed
the
make_shotover_peers_check_optional
branch
from
fbd7ba4 to
d0aaa6c
Compare
justinweng-instaclustr
approved these changes
Oct 15, 2024
ronycsdu
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the check_shotover_peers_delay_ms field optional.
When it is not provided the shotover peers check task is not started meaning that shotover nodes are always considered up and no TCP connections are created against shotover peers.
I think this field should be mandatory, we should force users to configure shotover to route around down shotover nodes, however, for now, lets make it optional to make it an easier transition.