Fix local_shotover_broker_id in test configs #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1765 will improve performances by 12.52%Comparing Summary
Benchmarks breakdown
|
rukai
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Nice catch!
Context for the next reviewer:
The local_shotover_broker_id field is currently only used for rack aware routing.
We weren't correctly setting it in our integration tests, the tests still passed since rack aware routing is purely an optimization and not needed for correctness.
We really should fix these configs so that we are running our integration tests with a configuration closer to production.
The way the field works is it configures the broker id that shotover should become.
Shotover looks up the entry in shotover_nodes that has that broker id and acts as that node.
conorbros
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from Lucas's comment below:
The
local_shotover_broker_idfield is currently only used for rack aware routing.We weren't correctly setting it in our integration tests, the tests still passed since rack aware routing is purely an optimization and not needed for correctness.
We really should fix these configs so that we are running our integration tests with a configuration closer to production.
The way the field works is it configures the broker id that shotover should become.
Shotover looks up the entry in
shotover_nodesthat has that broker id and acts as that node.