Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windsock: measure consume latency #1753

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Sep 19, 2024

Updates to latest windsock, making use of the new consumer latency functionality.
To calculate the consumer latency we:

  • serialize the current SystemTime in the first 12 bytes of the produced record payload
  • take those bytes from the consumed record payload and turn them back into a SystemTime then call .elapsed() to determine the amount of time passed.

This matches the behaviour of rdkafka_performance: https://github.com/confluentinc/librdkafka/blob/master/examples/rdkafka_performance.c

I did not use a serialization library for this as I need to ensure they fit exactly into 12 bytes so we know what our minimum size of payload needs to be.

As a result of the new minimum of 12 bytes, the existing 1B bench case was turned into a 12B bench case.

Copy link

codspeed-hq bot commented Sep 19, 2024

CodSpeed Performance Report

Merging #1753 will not alter performance

Comparing rukai:windsock_consume_latency (8415fe5) with main (4853f84)

Summary

✅ 39 untouched benchmarks

@rukai rukai force-pushed the windsock_consume_latency branch 3 times, most recently from e5eaa49 to 257e1f4 Compare September 19, 2024 06:36
@rukai rukai marked this pull request as ready for review September 19, 2024 06:42
@rukai rukai force-pushed the windsock_consume_latency branch from 257e1f4 to 8415fe5 Compare September 19, 2024 06:45
@rukai rukai merged commit 4693aab into shotover:main Sep 20, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants