KafkaSinkCluster - add multi_partition integration test case #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
kafka_multi_partition_test_case
branch
2 times, most recently
from
eab4f91 to
45eb16b
Compare
CodSpeed Performance ReportMerging #1749 will not alter performanceComparing Summary
|
rukai
force-pushed
the
kafka_multi_partition_test_case
branch
from
45eb16b to
e31a2b9
Compare
rukai
force-pushed
the
kafka_multi_partition_test_case
branch
from
c68494c to
6a26d5f
Compare
ronycsdu
approved these changes
Sep 17, 2024
justinweng-instaclustr
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this test case to try to reproduce an issue were we were hitting sequence out of order errors.
It turns out that issue was only occurring in a very old version of shotover, but this integration test represents a unique case that is worth testing, so lets land it.
This PR also renames the topics
batch_test_partitions_*->multi_topic_batch_partitions_*to extend the naming scheme to include the new topics introduced by this PR.