Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kafka-protocol crate #1736

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Conversation

rukai
Copy link
Member

@rukai rukai commented Aug 27, 2024

No description provided.

Copy link

codspeed-hq bot commented Aug 27, 2024

CodSpeed Performance Report

Merging #1736 will improve performances by 19.44%

Comparing rukai:update_kafka_protocol (7043165) with main (1df76ce)

Summary

⚡ 5 improvements
✅ 34 untouched benchmarks

Benchmarks breakdown

Benchmark main rukai:update_kafka_protocol Change
encode_all 22.9 µs 19.2 µs +19.44%
encode_request_fetch 14 µs 12.4 µs +13.43%
encode_request_list_offsets 12.9 µs 11.3 µs +14.5%
encode_request_metadata 13.3 µs 11.2 µs +18.96%
encode_request_produce 9.9 µs 8.3 µs +19.15%

@rukai rukai force-pushed the update_kafka_protocol branch 4 times, most recently from 2170d71 to 42ef2fa Compare September 4, 2024 01:51
@rukai rukai force-pushed the update_kafka_protocol branch from 42ef2fa to 96dd342 Compare September 4, 2024 05:11
@rukai rukai marked this pull request as ready for review September 4, 2024 05:50
@rukai rukai enabled auto-merge (squash) September 9, 2024 23:47
@rukai rukai merged commit 7ce587b into shotover:main Sep 10, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants