KafkaSinkCluster: use leader_epoch #1660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to change our metadata response processing to store each partitions leader_epoch and make use of it when updating our partitions metadata state.
We should only update a partition when the leader epoch in the response is newer (a smaller integer) than the existing epoch. This ensures that if we get the metadata from a node that is a bit out of date we dont regress the state of the metadata.
However in order to enable cleaning up of deleted partitions we should still delete partitions if missing in the response, since otherwise there would be no way to clean these up.
This PR implements this.