Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster: use leader_epoch #1660

Merged
merged 2 commits into from
Jun 13, 2024
Merged

KafkaSinkCluster: use leader_epoch #1660

merged 2 commits into from
Jun 13, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Jun 12, 2024

We need to change our metadata response processing to store each partitions leader_epoch and make use of it when updating our partitions metadata state.
We should only update a partition when the leader epoch in the response is newer (a smaller integer) than the existing epoch. This ensures that if we get the metadata from a node that is a bit out of date we dont regress the state of the metadata.
However in order to enable cleaning up of deleted partitions we should still delete partitions if missing in the response, since otherwise there would be no way to clean these up.

This PR implements this.

@rukai rukai force-pushed the leader_epoch branch 2 times, most recently from dcbc9fc to c01a05c Compare June 12, 2024 07:54
Copy link

codspeed-hq bot commented Jun 12, 2024

CodSpeed Performance Report

Merging #1660 will not alter performance

Comparing rukai:leader_epoch (00635f5) with main (9f89390)

Summary

✅ 37 untouched benchmarks

@rukai rukai marked this pull request as ready for review June 12, 2024 22:30
@rukai rukai merged commit 42ed20d into shotover:main Jun 13, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants