#1611 Allow disabling Shotover metrics #1655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the field
observability_interface
optional inconfiguration.yaml
. The Shotover metrics reporting will be disabled when this field is not specified.A test function has been added to verify Shotover can still process Redis requests with metrics disabled. As discussed with @rukai, we don't need to check that querying the prometheus endpoint returns the error of connection refused because the endpoint address is not specified at all.
Closes #1611