Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1611 Allow disabling Shotover metrics #1655

Conversation

justinweng-instaclustr
Copy link
Collaborator

This PR makes the field observability_interface optional in configuration.yaml. The Shotover metrics reporting will be disabled when this field is not specified.

A test function has been added to verify Shotover can still process Redis requests with metrics disabled. As discussed with @rukai, we don't need to check that querying the prometheus endpoint returns the error of connection refused because the endpoint address is not specified at all.

Closes #1611

Copy link

codspeed-hq bot commented Jun 5, 2024

CodSpeed Performance Report

Merging #1655 will not alter performance

Comparing justinweng-instaclustr:1611-allow-disabling-metrics-reporting (4a1182d) with main (f8dfaac)

Summary

✅ 37 untouched benchmarks

@justinweng-instaclustr justinweng-instaclustr marked this pull request as ready for review June 5, 2024 04:59
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Good thinking to update the docs.

@justinweng-instaclustr justinweng-instaclustr merged commit d9e441f into shotover:main Jun 5, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling metrics reporting
4 participants