KafkaSinkCluster scram_over_mtls - full integration tests #1651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the test cases added in #1652
It introduces a very similar case, run on a fresh shotover instance but running the stages of the test in a different order, in an effort to find possible token usage edge cases.
In doing so it uncovered a race condition in shotover.
When parsing metadata responses, we were previously updating the local nodes list only when the node was new globally.
However this is incorrect, we may still need to update the local nodes list even if the node is not new globally.
So this PR fixes this issue by pulling
self.update_local_nodes()
out of theif new {
statement.I've also left in a debug implementation for KafkaNode since I've found that we often want to be able to include it in temporary debug logs when investigating kafka bugs.