Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster: run java driver against standard test suite #1645

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented May 31, 2024

closes #1641

Make sure to enable "Hide Whitespace" when reviewing.

auto topic creation is an optional functionality of kafka enabled on the broker by auto.create.topics.enable.
When this is enabled, if a broker receives a produce request for a topic that does not exist, that topic is automatically created.

This PR makes two fixes:

  • Do not fail the transform when an UnknownTopicOrPartition error occurs. This error is expected since the client can send unknown topics when performing auto topic creation.
  • No longer report a warning when we route a produce request to a random node. Routing to a random node actually occurs in regular usage when auto topic creation is enabled, so warning is not appropriate here. Instead I reduced the warning to a debug, it is kept to aid in tracking down routing issues in the future.

This allows us to completely replace minimal_test_suite with standard_test_suite.

Copy link

codspeed-hq bot commented May 31, 2024

CodSpeed Performance Report

Merging #1645 will not alter performance

Comparing rukai:kafka_java_standard_test_suite (28b7c95) with main (a9ff518)

Summary

✅ 37 untouched benchmarks

@rukai rukai marked this pull request as ready for review May 31, 2024 07:23
@rukai rukai force-pushed the kafka_java_standard_test_suite branch from 00705b3 to 9dcefb1 Compare June 2, 2024 23:48
@rukai rukai requested a review from conorbros June 2, 2024 23:51
@conorbros conorbros merged commit ec2a06d into shotover:main Jun 4, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KafkaSinkCluster - java driver fails some tests
3 participants