KafkaSinkCluster: increment out_of_rack_requests metric for all out of rack requests #1639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1526
I thought the
out_of_rack_requests
metric would need to be reported at the routing stage.Which is why I left it for a follow up PR, I thought it was going to require modifications to all of our
route_to_*
methods.But it turns out its far simpler to just report it at the sending stage, which is what this PR does.
We just compare the rack of the node we are about to send against shotover's rack and record the metric if there is a mismatch.
I left a
tracing::debug
at the previous location ofself.out_of_rack_requests.increment(1);
to help disambiguate why we are getting out of rack requests.