Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster: increment out_of_rack_requests metric for all out of rack requests #1639

Merged
merged 2 commits into from
May 31, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented May 29, 2024

closes #1526

I thought the out_of_rack_requests metric would need to be reported at the routing stage.
Which is why I left it for a follow up PR, I thought it was going to require modifications to all of our route_to_* methods.
But it turns out its far simpler to just report it at the sending stage, which is what this PR does.
We just compare the rack of the node we are about to send against shotover's rack and record the metric if there is a mismatch.

I left a tracing::debug at the previous location of self.out_of_rack_requests.increment(1); to help disambiguate why we are getting out of rack requests.

Copy link

codspeed-hq bot commented May 29, 2024

CodSpeed Performance Report

Merging #1639 will not alter performance

Comparing rukai:kafka_out_of_rack_requests (e7700e7) with main (bb9f2b6)

Summary

✅ 37 untouched benchmarks

@rukai rukai marked this pull request as ready for review May 29, 2024 06:10
@rukai rukai requested a review from conorbros May 29, 2024 07:05
@rukai rukai force-pushed the kafka_out_of_rack_requests branch from c38dbfe to fbc0e21 Compare May 31, 2024 00:15
@rukai rukai enabled auto-merge (squash) May 31, 2024 01:01
@rukai rukai merged commit 60d7caa into shotover:main May 31, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KafkaSinkCluster is rack aware
3 participants