KafkaSinkCluster: Improve unknown topic warnings #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1629 will not alter performanceComparing Summary
|
conorbros
approved these changes
May 17, 2024
ronycsdu
approved these changes
May 21, 2024
justinweng-instaclustr
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we attempt to route a fetch request for which we have no record of its topic we issue a warning since it is impossible to route correctly.
We were previously including the topic name (
topicfield) in the warning but the kafka protocol has deprecated the topic name in favor of the topic uuid (topic_idfield) .This was resulting in warnings that look like:
no known partition replica for topic "", routing message to a random node so that a NOT_LEADER_OR_FOLLOWER or similar error is returned to the clientSo this PR now uses the topic name if provided and fallsback to the topic id when needed.