Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port RedisSinkSingle to try_recv #1620

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rukai
Copy link
Member

@rukai rukai commented May 9, 2024

closes #1609

Progress towards #1507

checking CI

I hit a problem with cassandra_int_tests::cassandra_redis_cache.
SimpleRedisCache will send requests into the same connection from two locations in the transforms logic.

  • One location expects responses to be returned immediately. - bad
  • The other expects responses to be handled on future transform calls - good

We will need to change the bad case to collaborate with the good case on handling responses back from the connection.

There is no clear performance improvement from this change, so I need to investigate further.

Copy link

codspeed-hq bot commented May 22, 2024

CodSpeed Performance Report

Merging #1620 will not alter performance

Comparing rukai:redis_single_try_recv (62d0e9e) with main (6fb74a2)

Summary

✅ 37 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port RedisSinkSingle to use try_recv instead of recv
1 participant