Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progress towards #1507
This PR introduces a way for transforms to force a chain run via a Notify passed to the transform build method.
This will enable 3 things to be implemented in future PRs:
Transform::transform_pushed
, instead push/event messages will go throughTransform::transform
I have also changed the
select!
in server.rs to be biased, I believe this is important since we should always process the force_run_chain branch if available to ensure that we consume the notify to avoid needlessly running the chain twice.With the move to biased, we also need the shutdown branch in the first position to ensure that we can still shutdown shotover while under heavy load.