Port Tee to MessageId #1506
Merged
Port Tee to MessageId #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
teeeeeee
branch
5 times, most recently
from
c70040f to
a4e11e5
Compare
conorbros
approved these changes
Feb 28, 2024
cjrolo
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately Tee was hit the hardest by the MessageId refactors.
That said we are getting some extra benefit from this PR: we now process mismatches at the message level instead of the batch level.
This means messages will no longer fail due to unrelated messages in the same batch failing.
This was done in this PR since working with MessageId's requires working at the per message level.