Refactor kafka_int_tests to use connection creator helper #1495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driving factor for this was the ability to abstract over connections created with TLS, TLS+SASL,plaintext+SASL or just plaintext.
In the future I expect this to also be useful for abstracting over different kafka drivers.
The consumer and producer APIs are completely abstracted and the tests no longer directly interact with rdkafka.
However the rdkafka admin API is still directly exposed since that has a lot more surface area.
We can wrap that up if and when we need to abstract over multiple kafka drivers.