Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisClusterPortsRewrite port to MessageId #1485

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Feb 19, 2024

Makes use of the new invariants introduced in #1476

@rukai rukai changed the title ClusterPortsRewrite port to MessageId RedisClusterPortsRewrite port to MessageId Feb 19, 2024
@rukai rukai requested a review from conorbros February 19, 2024 06:44
@rukai rukai enabled auto-merge (squash) February 19, 2024 10:56
Copy link

7 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/7958429882

                        No change in performance detected.
Found 4 outliers among 100 measurements (4.00%)
  3 (3.00%) high mild
  1 (1.00%) high severe
transform/nullsink      time:   [983.32 ns 993.95 ns 1.0038 µs]
                        change: [+21.374% +23.293% +25.157%] (p = 0.00 < 0.05)
                        Performance has regressed.
--
                        time:   [358.70 ns 365.00 ns 370.52 ns]
                        change: [+4.0599% +5.6323% +7.1887%] (p = 0.00 < 0.05)
                        Change within noise threshold.
kafka_codec/decode_request_metadata_drop
                        time:   [213.51 ns 223.81 ns 235.77 ns]
                        change: [+22.395% +28.284% +34.661%] (p = 0.00 < 0.05)
                        Performance has regressed.
--
Found 3 outliers among 100 measurements (3.00%)
  1 (1.00%) high mild
  2 (2.00%) high severe
kafka_codec/decode_request_list_offsets_drop
                        time:   [333.41 ns 341.59 ns 349.79 ns]
                        change: [+22.701% +28.119% +33.232%] (p = 0.00 < 0.05)
                        Performance has regressed.
--
Found 5 outliers among 100 measurements (5.00%)
  4 (4.00%) high mild
  1 (1.00%) high severe
kafka_codec/decode_request_fetch_drop
                        time:   [325.43 ns 337.64 ns 350.37 ns]
                        change: [+24.853% +30.482% +36.093%] (p = 0.00 < 0.05)
                        Performance has regressed.
--
Found 6 outliers among 100 measurements (6.00%)
  5 (5.00%) high mild
  1 (1.00%) high severe
kafka_codec/decode_request_produce_drop
                        time:   [585.95 ns 616.85 ns 643.84 ns]
                        change: [+54.827% +66.539% +78.774%] (p = 0.00 < 0.05)
                        Performance has regressed.
kafka_codec/encode_request_produce
                        time:   [1.3568 µs 1.3944 µs 1.4268 µs]
                        change: [+32.737% +84.774% +139.88%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 15 outliers among 100 measurements (15.00%)
  14 (14.00%) low mild
  1 (1.00%) high severe
kafka_codec/encode_all  time:   [2.3130 µs 2.3746 µs 2.4310 µs]
                        change: [+36.167% +43.054% +49.868%] (p = 0.00 < 0.05)
                        Performance has regressed.

@rukai rukai merged commit 022529e into shotover:main Feb 19, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants