-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cassandra 5 functions #1474
Cassandra 5 functions #1474
Conversation
4 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/7868145645
|
the microbenchmarks have been noisier since #1459 and your PR clearly wouldnt affect them so dont worry about it. |
#1468 seems to be a prereq for this PR so I've marked this as draft. |
402e942
to
4eeed6c
Compare
1 benchmark regressed. 2 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/7895625309
|
3d7715a
to
88a878e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We get to run the whole suite now, nice!
Using java over javascript makes sense to me, no point in testing deprecated features IMO.
The only changes are to shotover-proxy/tests/cassandra_int_tests/functions.rs. The rest is from the cluster tests PR.
Javascript functions have been deprecated in Cassandra 5 so I have switched our function tests to Java.