-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metrics crate #1462
Update metrics crate #1462
Conversation
3 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/7825599844
|
3 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/7825959195
|
I am no longer seeing the performance regression on CI or locally since #1463 was merged |
5 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/7843569995
|
The shortcut macros like
counter!
have been removed and the register macros likeregister_counter!
have been renamed likecounter!
.The register macros can be used in place of the shortcut macros since the shortcut macros were just registering and dropping a metric internally anyway.