Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics crate #1462

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Update metrics crate #1462

merged 2 commits into from
Feb 9, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Feb 8, 2024

The shortcut macros like counter! have been removed and the register macros like register_counter! have been renamed like counter!.
The register macros can be used in place of the shortcut macros since the shortcut macros were just registering and dropping a metric internally anyway.

Copy link

github-actions bot commented Feb 8, 2024

3 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/7825599844

transform/loopback      time:   [318.64 ns 319.21 ns 319.74 ns]
                        change: [+50.863% +51.133% +51.447%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
transform/nullsink      time:   [501.65 ns 502.20 ns 502.81 ns]
                        change: [+27.432% +27.729% +28.018%] (p = 0.00 < 0.05)
                        Performance has regressed.
--
Found 4 outliers among 100 measurements (4.00%)
  1 (1.00%) high mild
  3 (3.00%) high severe
transform/cassandra_request_throttling_unparsed
                        time:   [567.19 ns 567.61 ns 568.15 ns]
                        change: [+20.034% +20.958% +21.748%] (p = 0.00 < 0.05)
                        Performance has regressed.

@shotover shotover deleted a comment from github-actions bot Feb 8, 2024
@shotover shotover deleted a comment from github-actions bot Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

3 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/7825959195

transform/loopback      time:   [314.44 ns 315.36 ns 316.32 ns]
                        change: [+48.974% +49.567% +50.120%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
transform/nullsink      time:   [496.94 ns 497.57 ns 498.24 ns]
                        change: [+29.954% +38.933% +57.246%] (p = 0.00 < 0.05)
                        Performance has regressed.
--
  3 (3.00%) low mild
  1 (1.00%) high mild
  4 (4.00%) high severe
transform/redis_cluster_ports_rewrite
                        time:   [755.32 ns 756.11 ns 757.08 ns]
                        change: [+21.735% +23.087% +23.872%] (p = 0.00 < 0.05)
                        Performance has regressed.

@rukai rukai marked this pull request as ready for review February 8, 2024 21:33
@rukai rukai requested a review from conorbros February 8, 2024 22:16
@rukai
Copy link
Member Author

rukai commented Feb 8, 2024

I am no longer seeing the performance regression on CI or locally since #1463 was merged

@rukai rukai enabled auto-merge (squash) February 9, 2024 11:56
Copy link

github-actions bot commented Feb 9, 2024

5 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/7843569995

Found 7 outliers among 100 measurements (7.00%)
  7 (7.00%) high mild

cassandra_codec/encode_system.local_query_v4_no_compression
                        time:   [1.2517 µs 1.2993 µs 1.3440 µs]
                        change: [+38.058% +44.342% +51.288%] (p = 0.00 < 0.05)
                        Performance has regressed.
--
                        No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high severe
cassandra_codec/encode_system.local_result_v4_no_compression
                        time:   [29.273 µs 30.447 µs 31.556 µs]
                        change: [+44.921% +51.023% +57.472%] (p = 0.00 < 0.05)
                        Performance has regressed.
--
  3 (3.00%) low mild
  6 (6.00%) high mild
  4 (4.00%) high severe
cassandra_codec/encode_system.local_query_v5_no_compression
                        time:   [1.6189 µs 1.6781 µs 1.7281 µs]
                        change: [+32.752% +40.243% +48.206%] (p = 0.00 < 0.05)
                        Performance has regressed.
--
  8 (8.00%) low mild
  5 (5.00%) high mild
  2 (2.00%) high severe
cassandra_codec/encode_system.local_query_v5_lz4_compression
                        time:   [1.7170 µs 1.7898 µs 1.8561 µs]
                        change: [+21.872% +31.686% +43.555%] (p = 0.00 < 0.05)
                        Performance has regressed.
--
                        Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high mild
cassandra_codec/encode_system.local_result_v5_lz4_compression
                        time:   [47.390 µs 48.932 µs 50.248 µs]
                        change: [+24.853% +28.755% +32.796%] (p = 0.00 < 0.05)
                        Performance has regressed.

@rukai rukai merged commit c992dc4 into shotover:main Feb 9, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants