Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fully replace library/cassandra with shotover/cassandra-test image #1460

Merged
merged 2 commits into from
Feb 8, 2024
Merged

fully replace library/cassandra with shotover/cassandra-test image #1460

merged 2 commits into from
Feb 8, 2024

Conversation

conorbros
Copy link
Member

No description provided.

@conorbros conorbros force-pushed the remove-image-watier branch from c347c9d to 38054f6 Compare February 8, 2024 02:04
@conorbros conorbros force-pushed the remove-image-watier branch from cd0388d to 70ba7f4 Compare February 8, 2024 06:04
@conorbros conorbros requested a review from rukai February 8, 2024 06:05
@rukai
Copy link
Member

rukai commented Feb 8, 2024 •
edited
Loading

huh, that is less tokens then the other clusters have.
I'm counting 16 * 6 tokens = 96
Whereas the other clusters have 128 * 3 = 384

Maybe cassandra 5 decreased the default token count?
Or maybe its a 6 node cluster thing?

@conorbros
Copy link
Member Author

conorbros commented Feb 8, 2024 •
edited
Loading

It's not Cassandra 5.

rukai
rukai approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whats up with the token count but considering this is for an integration test not a benchmark, as long as we have more than one token for each node it should be fine.

@rukai
Copy link
Member

rukai commented Feb 8, 2024

It's not Cassandra 5.

Oh true I got it mixed up with the other PR, oops.

@rukai rukai changed the title remove unused image waiter fully replace library/cassandra with Ssotover/cassandra image Feb 8, 2024
@rukai rukai changed the title fully replace library/cassandra with Ssotover/cassandra image fully replace library/cassandra with shotover/cassandra image Feb 8, 2024
@rukai rukai changed the title fully replace library/cassandra with shotover/cassandra image fully replace library/cassandra with shotover/cassandra-test image Feb 8, 2024
@conorbros conorbros merged commit 547704d into shotover:main Feb 8, 2024
40 checks passed
@conorbros conorbros deleted the remove-image-watier branch May 23, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukai rukai rukai approved these changes

@cjrolo cjrolo cjrolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conorbros @rukai @cjrolo