Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cassandra 5 single tests #1454

Merged
merged 3 commits into from
Feb 9, 2024
Merged

cassandra 5 single tests #1454

merged 3 commits into from
Feb 9, 2024

Conversation

conorbros
Copy link
Member

@conorbros conorbros commented Feb 6, 2024 •
edited
Loading

pending:

@rukai
Copy link
Member

rukai commented Feb 7, 2024

Lets land the absolute bare minimum first.
vectors and other cassandra 5 features can come later.
I'll review https://github.com/shotover/cassandra-test-images/pull/5/files asap

@rukai
Copy link
Member

rukai commented Feb 8, 2024

https://hub.docker.com/layers/shotover/cassandra-test/5.0-beta1-r2/images/sha256-261210443b941dc0fd9a0347cf43637c41275dfa490ff8bab072dd8777145e46?context=explore the new image is now available

@conorbros conorbros marked this pull request as ready for review February 8, 2024 23:49
@conorbros
Copy link
Member Author

Only Java user defined functions are supported in Cassandra 5. Lets merge this with the bare minimum and I'll open another PR for testing UDF in Cassandra 5.

rukai
rukai approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!
Thanks for taking this on.

@conorbros conorbros changed the title cassandra 5 tests cassandra 5 single tests Feb 9, 2024
@conorbros conorbros requested a review from cjrolo February 9, 2024 04:05
@conorbros conorbros merged commit 78c6960 into shotover:main Feb 9, 2024
40 checks passed
@conorbros conorbros deleted the cassandra-5 branch February 9, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukai rukai rukai approved these changes

@cjrolo cjrolo cjrolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conorbros @rukai @cjrolo