Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the chain registers metrics for all its transforms but then throws away the handles, requiring the transforms to access the metrics without the handles.
This currently works fine however there are two issues with this:
transform_pushed_*
metrics.This PR fixes those two issues by holding onto the handles and then using them later on for recording metrics.
After the change I can now see:
transform/loopback
micro benchmark introduced by add loopback microbenchmark #1402 (I had to alter it slightly to enable metrics otherwise the difference wont show up)