Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new windsock profiler (
--profilers shotover_metrics
) that fetches metrics from shotovers prometheus web interface.When I implemented sar based system metrics, I set it up to extract specific hardcoded metrics from the full pool of metrics collected by sar. This made sense there as:
However for prometheus metrics I opted to include all metrics as long as we know how to handle that type of metric.
My reasoning is:
Unfortunately this does come at the cost of not being able to define goals for some types of metrics.
Running with --cloud doesnt work yet due to EC2 security groups, this will be complicated to resolve, so for now lets land as is because I dont need it to work in the cloud yet.
Running:
we get: